Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KIS-1.27.ckan #2235

Merged
merged 2 commits into from
Jan 16, 2021
Merged

Update KIS-1.27.ckan #2235

merged 2 commits into from
Jan 16, 2021

Conversation

Sinomen
Copy link
Contributor

@Sinomen Sinomen commented Jan 16, 2021

As per Ihsoft, when I asked if KIS 1.27 is compatible with KSP 1.10.1, he said "I assume it may not be compatible"

https://forum.kerbalspaceprogram.com/index.php?/topic/149848-minimum-ksp-version-111-kerbal-inventory-system-kis-v128/&do=findComment&comment=3898830

@Sinomen
Update KIS-1.27.ckan
07ff017 
As per Ihsoft, when I asked if KIS 1.27 is compatible with KSP 1.10.1, he said "I assume it may not be compatible"

https://forum.kerbalspaceprogram.com/index.php?/topic/149848-minimum-ksp-version-111-kerbal-inventory-system-kis-v128/&do=findComment&comment=3898830
@DasSkelett
Copy link
Member

DasSkelett commented Jan 16, 2021 •
edited
Loading

Hm, wasn't the discussion about the minimum version though? I.e. it only works on KSP 1.11.0 (and potentially upwards)?
Currently your commit changes the maximum KSP version, so that it would be compatible with KSP from 1.8.0 until (and including) 1.10.1.

@Sinomen
Copy link
Contributor Author

Sinomen commented Jan 16, 2021 •
edited
Loading

Darn, you are right, I DID botch it up :(

How to correct this?

@HebaruSan
Copy link
Member

HebaruSan commented Jan 16, 2021 •
edited
Loading

You should be able to edit again if you go to the files changed tab and click the pencil icon again (or click the ellipsis and choose "Edit file"?).

@DasSkelett
Copy link
Member

Oh now worries, that's what PRs are for, so someone can review it and catch potential errors.

You can edit the file again similar to how you did before
(The pencil icon on this page: https://github.com/Sinomen/CKAN-meta/blob/patch-1/KIS/KIS-1.27.ckan).

Make sure you keep the "Commit directly to the patch-1 branch." option selected this time, so it goes to the same branch.

@Sinomen
Copy link
Contributor Author

Sinomen commented Jan 16, 2021

Done. Correct now?

DasSkelett
DasSkelett approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, if I followed the discussion correctly, that's how it should be. Thanks a lot!

@DasSkelett DasSkelett merged commit 0900a7d into KSP-CKAN:master Jan 16, 2021
@HebaruSan
Copy link
Member

🎉

image

@Sinomen
Copy link
Contributor Author

Sinomen commented Jan 17, 2021

Cool, and thanks a lot for your help! :)

@Sinomen Sinomen deleted the patch-1 branch January 17, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasSkelett DasSkelett DasSkelett approved these changes

Assignees
No one assigned
Labels
Fix compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sinomen @DasSkelett @HebaruSan